search

johanneswuerbach / backstage-plugin-techdocs-addon-mermaid

Backstage TechDocs Mermaid Addon
MIT License
43 stars 18 forks source link

Breaks with mkdocs-techdocs-core 1.2.0 #29

Closed bforbis closed 1 year ago

bforbis commented 1 year ago

The latest mkdocs-techdocs-core version 1.2.0 does not render mermaid anymore with this addon. The last known working compatible version with this add-on is 1.1.7

markandersontrocme commented 1 year ago

@bforbis any idea what is causing this? If you have logs I can try to give it a look

johanneswuerbach commented 1 year ago

This should be fixed in https://github.com/johanneswuerbach/backstage-plugin-techdocs-addon-mermaid/releases/tag/v0.6.3

jtreher commented 1 year ago

hah, my goodness. I was just submitting an issue for this with the exact same fix. Should have checked the issues!

Steps to waste two hours:

  1. Look at how this thing parses the code fence.
  2. Inspect the HTML
    1. Look for all classes
    2. Realize class has moved from table to above div.
  3. Enthusiastically prepare the findings and suggest a fix.
  4. Search the issues and realize it's already done.
  5. Try to appreciate I know a little more about how this addon works now?