Closed johanhammar closed 1 week ago
This fixes https://github.com/johanneswuerbach/backstage-plugin-techdocs-addon-mermaid/issues/46 as well. Do you want me to add a test for this as well?
it("mermaid code exists with comment", () => {
const mermaidCode = `%% mermaid code with comment
graph LR
A-->B`;
const result = isMermaidCode(mermaidCode);
expect(result).toBe(true);
});
Do you want me to add a test for this as well?
I think it can't hurt as those quickly running unit tests. Thank you 🙇
Anything else I can do to get this merged? 🤔
Thanks for the bump and contribution ❤️ , released as backstage-plugin-techdocs-addon-mermaid@0.12.1
.
Support diagrams containing frontmatter directive. Might fix https://github.com/johanneswuerbach/backstage-plugin-techdocs-addon-mermaid/issues/48
Possibly a bit naive solution that seems to work, perhaps even the
codeSplitByDirectiveStart
block can be removed to with this fix?