Update saucie and work with its new command line options

johanneswuerbach / ember-cli-sauce

Cross browser testing for your ember-cli app using SauceLabs

MIT License

40 stars 14 forks source link

Update saucie and work with its new command line options #68

Closed marcoow closed 7 years ago

marcoow commented 7 years ago

This is the counterpart to johanneswuerbach/saucie#59

marcoow commented 7 years ago

Tests seem to be failing because sc and the sauce launcher use 2 different tunnel identifiers… While both should use process.env.TRAVIS_JOB_NUMBER actually, sc does:

--tunnel-identifier 238.1

while the sauce launcher uses

"tunnelIdentifier":"238"

What's funny is that this actually seems to work for saucie…

johanneswuerbach commented 7 years ago

Released saucie v3.0.0

johanneswuerbach commented 7 years ago

Published as v1.10.0, thanks again 🎉

Turbo87 commented 7 years ago

@johanneswuerbach this should've probably been a major version bump here too, as the launchers that previously worked with the old saucie most likely won't work anymore. I'd suggest republishing v1.9.x as v1.10.1 and the current master as v2.0.0.

johanneswuerbach commented 7 years ago

Yes, correct 🤕

Turbo87 commented 7 years ago

sorry, should've mentioned that earlier 😞

johanneswuerbach commented 7 years ago

Done!

Turbo87 commented 7 years ago

@johanneswuerbach awesome, thanks!