search

johanneswuerbach / saucie

This library allows you to integrate results of your frontend JavaScript tests into a [Sauce jobs results page](https://saucelabs.com/docs/javascript-unit-tests-integration).
26 stars 18 forks source link

allow requesting specific platform version #55

Closed marcoow closed 7 years ago

marcoow commented 7 years ago

This allows running tests on a particular version of the target OS which is especially helpful for mobile devices where there's only one browser version per OS version so being able to request a particular browser version doesn't help much.

Closes #53

marcoow commented 7 years ago

I'm actually not sure how the failing test is related to this as without this change it would just send "platform":"" which should actually be no different from sending it at all (which is the case with the changes in this PR)?

marcoow commented 7 years ago

Argh, sorry for the noise here - just realized Saucelabs takes different options for Selenium and Appium. Actually for Selenium you can specify the OS and version in one string whereas it expects two separate strings for Appium. I'll update this.

marcoow commented 7 years ago

updated - this will now build the "platform" string from the platformName and platformVersion arguments regardless of the platform used on Saucelab's side (which we don't know anyways I think).

johanneswuerbach commented 7 years ago

Not sure what advantage this change brings now, align the interface more with Appium?

marcoow commented 7 years ago

This allows running tests on different mobile OS versions which is not possible currently as Appium needs the platformVersion setting.

johanneswuerbach commented 7 years ago

Sorry, I don't understand. If you say -p Windows -pv XP or -p "Windows XP" you are passing the same platform string Windows XP to sauce. What additional advantage do I gain from using -pv instead of concatenating name and version myself?

Sorry scratch that, I was misreading the code 🤦‍♂️

johanneswuerbach commented 7 years ago

Could you rebase? This this is good to go.

marcoow commented 7 years ago

@johanneswuerbach: rebased

marcoow commented 7 years ago

🎉

johanneswuerbach commented 7 years ago

Published as 2.1.0, sorry for all the back and forth.

marcoow commented 7 years ago

awesome - thanks!