search

johanneswuerbach / saucie

This library allows you to integrate results of your frontend JavaScript tests into a [Sauce jobs results page](https://saucelabs.com/docs/javascript-unit-tests-integration).
26 stars 18 forks source link

Platform version is converted to number automatically #58

Closed marcoow closed 7 years ago

marcoow commented 7 years ago

The platform version argument is always converted to a number (as long as it looks like a number as e.g. 5.1). That's because of this line in minimist which optimist depends on. Flagging arguments as strings actually doesn't work as the argument is flagged with its long name but the check is performed with the short name. This is actually fixed in minimist but optimist (which is deprecated) depends on a very old version of it which doesn't include that change.

I'd suggest switching from optimist to minimist. I'd be happy to prepare a PR if there's consensus.

johanneswuerbach commented 7 years ago

Sounds good to me 👍

marcoow commented 7 years ago

minimist actually seems pretty unmaintained as well. Looks like commander is the most popular solution. Might make more sense to switch to that then?