search

johanneswuerbach / saucie

This library allows you to integrate results of your frontend JavaScript tests into a [Sauce jobs results page](https://saucelabs.com/docs/javascript-unit-tests-integration).
26 stars 18 forks source link

It's impossible to set `connectVersion` when using connect() #79

Closed makepanic closed 6 years ago

makepanic commented 6 years ago

Right now the options, passed to connect get overwritten by some defaults. This means it's impossible to overwrite these defaults.

https://github.com/johanneswuerbach/saucie/blob/master/lib/connect.js#L6

The easiest fix would be to change the Object.assign order to merge the default options with given options:

Object.assign({}, defaultOptions, opts);

If it's ok, I can open a PR to change the behavior.