johanneszab / TumblThree

A Tumblr Blog Backup Application
https://www.jzab.de/content/tumblthree
MIT License
921 stars 130 forks source link

Cannot download linked imgur albums #324

Open TinyTrbl opened 5 years ago

TinyTrbl commented 5 years ago

Hello.

Im really sorry for asking, but i cannot download imgur albums from new posts (2018) on NSFW artworks. "Download imgur" option is enabled.

Am I doing something wrong or it is not possible?

johanneszab commented 5 years ago

Looks like they are linked differently again in that blog. It's probably just a line of code (adjusting the regular expression in the Imgur parser), but for sure it could be the case that for that blog, you'll not be able to download the linked images.

If there would be one single way to do something, things would be too easy, really, ..

johanneszab commented 5 years ago

Well, I've actually looked into this, and couldn't get it easily working, .. then I tested the urls in the blog, and they are all dead as well. For example:

https://imgur.com/4B2BSpz https://imgur.com/T2FpMRQ

I'm not even sure if those have a valid format.

Edit: Where exactly is a imgur album link on that blog? Since I don't have any clue about imgur, I just clicked all the obvious links, none of them worked:

Zoinks! You've taken a wrong turn.

Let's split up, gang. If you're looking for an image, it's probably been deleted or may not have existed at all.

If you are looking for groovy images, visit our gallery!
TinyTrbl commented 5 years ago

I may sound weird, but all these imgur links worked yesterday... I'm not so stupid, i swear! Something happened in the last hours. :(

johanneszab commented 5 years ago

No, I believe you. I had similar experience when I was implementing the tumblr _raw photo detection. The current Imgur RegEx for album detection would also not detect those links above as they are in the form

https://imgur.com/4B2BSpz https://imgur.com/T2FpMRQ

instead of

https://imgur.com/a/4B2BSpz https://imgur.com/A/T2FpMRQ

without the a or A after the host.