Mimic Native ActionBar API

johannilsson / android-actionbar

DEPRECATED Android Action Bar Implementation

1.3k stars 564 forks source link

Mimic Native ActionBar API #25

Closed JakeWharton closed 13 years ago

JakeWharton commented 13 years ago

Mimic the API of the native ActionBar on Android 3.0+. This implements all of the methods using behavior that is follows as closely to the 3.0+ version's implementation as possible.

The example application has also been updated with buttons to demonstrate the new functionality.

JakeWharton commented 13 years ago

Added navigation modes for standard (title only) and list navigation.

JakeWharton commented 13 years ago

I believe I have everything except for tabbed navigation implemented. Been a crazy 24 hours of hacking all this support in but I think it turned out pretty well. I still have a few things on my TODO list other than tabbed navigation but they can wait a bit.

Check out the example app for a full demo of the new features.

QR Code

johannilsson commented 13 years ago

Wow, you've been busy at work! And it looks really really good, will see if I can fix the tabbed navigation soonish. Sorry that I has been slightly away but it's been a crazy week here.

slapperwan commented 13 years ago

Checked out the example and really like the navigation mode list :)

kottkrig commented 13 years ago

Amazing! Great work.

johannilsson commented 13 years ago

I've merged this to the branch mimic-native-api and added initial support for tabs.

Support for tabs is far from complete but it do look pretty good already even though it's hacked up and lack support for configuration and such, will continue the work during the week.

JakeWharton commented 13 years ago

Let me know what you think of JakeWharton/android-actionbar@0b3d97218adc265a67d8ecb7896abf5d9ef041d3. I can revert it if it is not the route you want to go in. It fixes #7 and is something I do in the custom version of your library that is used in the yet-unreleased ActionBarSherlock v3.

JakeWharton commented 13 years ago

Updated demo apk linked above for those interested.

Two problems i've noticed:

Custom tab views (or at least the simple one I have created) are distorted.
List view dropdown doesn't show d-pad selection. The selection with the d-pad works, but there is no state displayed on screen because the list items do not use the normal style.

johannilsson commented 13 years ago

Jake, this looks really good and you have made huge progress during the last days, I'm not too happy with the naming of the add methods but I guess I can get used to it and I see the benefits of implementing Menu. It might be possible to refactor out handling of action items to a separate view and have addAction methods to delagate to that view from the action bar, will have to think about that. My time is somewhat limited since I can only contribute a few hours each evening, but I will review and apply a few fixes as soon as I can.

I've started to work on the selection issues on the list view last night and I hope to finish that and a few other things during the week. I have also have a couple of uncommited fixes for the tab handling I hope I can wrap up really soon.

Anyway, thank you and I'm looking forward to ActionBarSherlock v3.

johannilsson commented 13 years ago

I've pushed a small fix yesterday that solves the list navigation problems with trackball, your latest changes is also merged to mimic-native-api.

JakeWharton commented 13 years ago

Closing this since you've already merged it into a topic branch and I want to delete my forked repo since a few people started to watch it instead of yours.