search

johannilsson / android-actionbar

DEPRECATED Android Action Bar Implementation
1.31k stars 564 forks source link

Different item style for the home item #53

Closed rfgamaral closed 12 years ago

rfgamaral commented 12 years ago

I felt the need to style the action bar home item independently from all other items (and title) and after digging a little bit into the library code, I come up with this.

It looked to me that the ActionBar_HomeItem style was defined but not being used anywhere. I basically put it to some use... Hopefully, this is the way to go to solve this particular issue.

This does not change any of the current behavior in the library. Everyone can easily upgrade without making any changes to their apps. Everything will still work perfectly fine.

johannilsson commented 12 years ago

Haven't looked into why yet, but it seems like the home action in the example apps OtherActivity is not affected. Still showing red, should be blue.

rfgamaral commented 12 years ago

The thing is, I added the feature and it was working on my own app because I was using it properly, but the example project was not. Actually, the example project was explicitly using the default style, which is red.

I found the issue and it's easy to fix, but it will be easier to merge if I do a new pull request because of changes done on #51.