search

johannschopplich / kirby-highlighter

🌐 Server-side syntax highlighting for the code block & KirbyText
https://kirbyseo.com
MIT License
20 stars 4 forks source link

fix: unicode encoding #24

Closed lemmon closed 2 months ago

lemmon commented 2 months ago

Fixes encoding within the PHP DOMDocument class including special characters and emojis.

johannschopplich commented 2 months ago

Thanks! I think it's time to drop the custom implementation in favor of use Kirby\Toolkit\Dom. Could you update the PR, please?

johannschopplich commented 2 months ago

Hey! Can you please update the PR based on my latest changes to replace the custom DOM class with Kirby's own Dom implementation? See https://github.com/johannschopplich/kirby-highlighter/commit/0e4404da1a324d2a26d14c9f4e37c294b5416014

johannschopplich commented 2 months ago

Maybe your issue is already resolved? Open for feedback. 🙏

lemmon commented 2 months ago

Yes, it is. 👌