johannschopplich / kirby-serp-preview

🔍 Kirby Panel plugin for search engine result page previews
https://kirbyseo.com
MIT License
17 stars 2 forks source link

KQL queries in faviconUrl #3

Closed carstengrimm closed 8 months ago

carstengrimm commented 9 months ago

testing out the serp preview section i notice that i can't use KQL to use the

"{{ site.url }}"/path/to/favicon.ico

it's not really important just mentioning

johannschopplich commented 9 months ago

Why do you need the site URL for the favicon, isn't the absolute path /path/to/favicon.ico sufficient?

johannschopplich commented 9 months ago

Thanks for the feedback!

carstengrimm commented 9 months ago

Why do you need the site URL for the favicon, isn't the absolute path /path/to/favicon.ico sufficient?

i am only developing locally. and using e.g.

/path/to/favicon.ico 

kirby panel does not seem to follow the root path so i would have to hardcode... (it may also just be a misconfiguration from me...)

/localdemo/assets/icon/favicon.ico

which may always change. just thinking it's more handy to have the flexibility for site.url