search

johannschopplich / kirby-vue3-starterkit

✨ Kirby + Vue SPA starter: automatic routing, i18n, SEO and more!
MIT License
206 stars 19 forks source link

Use .env mode files, and kirby in subfolder #51

Closed Small-Systems closed 1 year ago

Small-Systems commented 2 years ago
  1. Reformatting of vite.config so that .env mode files can be loaded, using loadEnv from Vite, rather than dotenv.
  2. Modified VueKit.php; changed the url returned in the functions assetProd, preloadJson, preloadModule.

The purpose of 2, is that when kirby is in a subfolder the urls will resolve correctly. This is not specific to your install, but I have kirby running in a subfolder on my testing server i.e; dev.domain.com/project.

johannschopplich commented 2 years ago

Great PR! Can you look at the two comments, please? Thanks in advance.

Small-Systems commented 2 years ago

Hi, I don't see any comments, where should I be looking? (I've never done a PR before) Thanks, Luke

johannschopplich commented 2 years ago

You should see them above, related to the code changes:

grafik

Small-Systems commented 2 years ago

That's weird, my conversation looks like this:

Screenshot 2022-10-10 at 11 30 08
johannschopplich commented 2 years ago

My bad, didn't request the changes…

johannschopplich commented 1 year ago

Hi there, I have manually merged your feature in https://github.com/johannschopplich/kirby-vue3-starterkit/commit/7e4c385e658c10c5781b195e11b9b92cafc28132, because your feature to deploy Kirby in a subfolder is a separate PR and will have to be tested thoroughly, so it won't break existing installations. Would you mind creating a new PR, thanks in advance!