search

johannschopplich / kirby-writer-marks

Custom marks for Kirby's writer field – footnote mark included
35 stars 6 forks source link

Footnote icon not showing up #3

Closed manspeterson closed 2 years ago

manspeterson commented 2 years ago

Hey,

Thanks for your wonderful job.

Just tried to install this patch and plugin for the first time today on a new empty project running the latest version of Kirby.

After running the patch successfully the footnote mark is registered within window.panel.plugins.marks. However the footnote icon does not show up among the other default marks while selecting text.

Could Kirby have introduced a breaking change in their latest versions or am I just missing something?

johannschopplich commented 2 years ago

Hi there, thanks for the flowers.

Have you made sure the Panel source is patched (node site/plugins/kirby-writer-marks/scripts/patchKirbyPanel.cjs from root)? You may need to delete the media/panel folder if you have logged into the Panel before applying the patcher.

Once the patcher is applied, you will see the footnote mark on the far-right side of the writer toolbar (given the plugin is in site/plugins, which it is, since the patcher wouldn't have worked before).

It is ensured to work with the latest Kirby version, even Kirby 3.6. Could you provide a minimum reproducible example?

manspeterson commented 2 years ago

OMG. Of course it was the media/panel folder that was behind it... My bad. Thank you!

johannschopplich commented 2 years ago

@manspeterson Good point tho, I have added a warning to the docs in https://github.com/johannschopplich/kirby-writer-marks/commit/48557952d590860aceef4c29a94c9148341c41ba.

herrajon commented 2 years ago

@johannschopplich Could be worth mentioning too clear the browser cache as well.