johannschopplich / kirby-writer-marks

Custom marks for Kirby's writer field – footnote mark included
35 stars 6 forks source link

Handle Popup/Dialog #5

Closed marco-land closed 2 years ago

marco-land commented 2 years ago

Great plugin and very nice to see how it has improved over the last months!

One thing that is not quite clear to me is how to handle pop ups/dialogs with a custom mark. For example, the link mark has the input fields url / title / open in new window.

I tried to compare/understand the original link.js file and also noticed the Dialog folder but do not understand yet how to add these.

In my opinion the example footnote mark is also missing this part because the footnotes are missing content otherwise, or am I overseeing something? If this is already possible it might be helpful to add this to the footnote example.

johannschopplich commented 2 years ago

Hi there,

thanks for the flowers! The footnote example mark uses the custom element <article-footnote /> and doesn't need a dialog element. It is up to you to parse footnotes in your article. The footnote mark probably won't be extended; its current scope should stay lean and comprehensible.

For a more comprehensive example, I highly recommend kirby-extended-writer, which is built upon this plugin!