feat: custom `hashFn` composable option

johannschopplich commented 1 year ago

🔗 Linked issue

Idea from #50

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

@killjoy1221 To ease the need for your composable overwriting the hashing logic, why not add an option to the composable itself? What do you think? You could simplify your custom composable.

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

netlify[bot] commented 1 year ago

Deploy Preview for nuxt-api-party ready!

Name	Link
Latest commit	47a37cafb6db84f83bbc95a9f191c5d6ee2b17bb
Latest deploy log	https://app.netlify.com/sites/nuxt-api-party/deploys/650363da10759b000899aae5
Deploy Preview	https://deploy-preview-51--nuxt-api-party.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mattmess1221 commented 1 year ago

What about also providing the key as a plain string the same way useAsyncData does?

useMyData("key", "path")

johannschopplich commented 1 year ago

That's probably the more native solution. 😃

johannschopplich / nuxt-api-party