feat!: update module options

johannschopplich / nuxt-gtag

🔸 Google Analytics & Ads integration made easy

https://developers.google.com/tag-platform/gtagjs

MIT License

302 stars 9 forks source link

feat!: update module options #62

Closed DamianGlowala closed 2 months ago

DamianGlowala commented 7 months ago

🔗 Linked issue

resolves https://github.com/johannschopplich/nuxt-gtag/issues/59

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds initMode option and changes the purpose of enabled one.

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

netlify[bot] commented 7 months ago

Deploy Preview for nuxt-gtag ready!

Name	Link
Latest commit	8755ba18fcfb897281d74858de1e7963e915145b
Latest deploy log	https://app.netlify.com/sites/nuxt-gtag/deploys/66229964e4d61600086be4bf
Deploy Preview	https://deploy-preview-62--nuxt-gtag.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

johannschopplich commented 6 months ago

Great idea. Let's wait until this module has been moved to the @nuxtjs namespace. After the migration, I will release a new major version.

DamianGlowala commented 6 months ago

Sure!

When working on this PR, I was wondering whether it would make sense for this module to expose isInitialized flag (the one which currently is declared in the playground? Let me know if it would bring any value and I can add it :)

johannschopplich commented 6 months ago

Yeah, absolutely! Would be a great addition to check if one (or multiple) IDs have been activated already.

johannschopplich commented 2 months ago

Thanks for the PR! I've implemented the changes manually while also updating the README.