Remove `dev` flag from setup install commands

johannschopplich / nuxt-gtag

🔸 Google Analytics & Ads integration made easy

https://developers.google.com/tag-platform/gtagjs

MIT License

302 stars 9 forks source link

Remove `dev` flag from setup install commands #7

Closed pascalwengerter closed 1 year ago

pascalwengerter commented 1 year ago

❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSDoc annotations)

📚 Description

Arguably, the code provided when using this plugin runs in the client/within the production bundle and therefore should count as a "full" dependency?

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

netlify[bot] commented 1 year ago

Deploy Preview for nuxt-gtag ready!

Name	Link
Latest commit	83e0e8162a7cb2aa7b4f34556f703e30577476f1
Latest deploy log	https://app.netlify.com/sites/nuxt-gtag/deploys/6421b67bc014fa000870b8ea
Deploy Preview	https://deploy-preview-7--nuxt-gtag.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

johannschopplich commented 1 year ago

Thanks for the input! Technically speaking, every Nuxt module is a dev dependency, since Nuxt will consume it to build the server and client bundle. There is no way of using any Nuxt module just via importing it in the client. It will always be procesed by the Nuxt build chain. Thus, a dev dependency.

I think it's best practice to treat every Nuxt dependency as a dev dependency.

For example, the offical Nuxt image module is a dev dep as well.