johannschopplich / nuxt-gtag

🔸 Google Analytics & Ads integration made easy
https://developers.google.com/tag-platform/gtagjs
MIT License
302 stars 9 forks source link

Ensure plugin types are exposed #82

Closed junemolison closed 4 months ago

junemolison commented 4 months ago

chore: release v2.0.7 chore: update deps fix: ensure plugin types are exposed

🔗 Linked issue

📚 Description

Fixed import of defineNuxtPlugin to properly expose types accordingly to template: https://github.com/nuxt/starter/blob/module/src/runtime/plugin.ts

netlify[bot] commented 4 months ago

Deploy Preview for nuxt-gtag ready!

Name Link
Latest commit fb6106dbd4bc08b2deb46bbedcc0e5da2a1d1de3
Latest deploy log https://app.netlify.com/sites/nuxt-gtag/deploys/668bc74bd5bf720007f39e88
Deploy Preview https://deploy-preview-82--nuxt-gtag.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

johannschopplich commented 4 months ago

Thanks for the PR! But why not keep #imports, do you run into any issues?

johannschopplich commented 4 months ago

I believe using #imports is the correct way here, as all other Nuxt modules use it at the moment. For example:

https://github.com/nuxt-modules/color-mode/blob/0aed5962b4b6e2880f90c713b6773624e276bcec/src/runtime/plugin.client.ts#L4