search

johansatge / pawnee

🪶 An Apache GUI for OSX.
MIT License
94 stars 14 forks source link

Icon for dark menubar #9

Open Grawl opened 6 years ago

Grawl commented 6 years ago

I can't see app is launched before I turned off "Use dark menu bar and Dock" option into system general settings.

Please, provide an inverted (white) menubar icon version.

johansatge commented 6 years ago

Hi,

thanks for the report.

The code should handle this case by using the icon and alticon properties of the Tray, but it does not seem to work (anymore? I'm testing on macOS 10.12.5)

https://github.com/johansatge/pawnee/blob/116f2194f1eb09d9fc6d35b264c89a8ac99f8096/app/assets/js/app.js#L113-L114

If someone wants to have a look, please feel free to do so - maybe updating nwjs to a more recent version would fix the issue?

Grawl commented 6 years ago

I just figured out that inverted icon is applied but not rendered at all on dark menubar. Until I clicked on place where it should be.

Grawl commented 6 years ago

pawnee dark menubar icon bug