search

johanvts / emacs-fireplace

A cozy fireplace for emacs.
732 stars 21 forks source link

Rendering issues #10

Closed davidw closed 8 years ago

davidw commented 8 years ago

I just see a solid red buffer with no actual fire.

Adding smoke makes the top of the fire visible.

GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.16.6) of 2015-09-17 on lgw01-52, modified by Debian

w1gz commented 8 years ago

Same issue (with the smoke trick too) on GNU Emacs 24.5.1 (x86_64-redhat-linux-gnu, GTK+ Version 3.17.8) of 2015-09-11 on buildvm-21.phx2.fedoraproject.org

johanvts commented 8 years ago

Thanks. I saw some comments that ''visual-line-mode'' or ''truncate-lines'' might break the fireplace. Can you try flipping those and checking if that helps?

w1gz commented 8 years ago

Ok, you're on to something @johanvts. I did try visual+truncate but they were already off. So I basically disabled my .emacs and the fireplace was working !

To help others, my naughty line was : (setq-default show-trailing-whitespace t).

I can now enjoy a nice fire, thanks to you @johanvts.

thomas-louvigne commented 8 years ago

Still have a bug ... Any idea ?

img

w1gz commented 8 years ago

@zobi8225 remove your .emacs entirely and retry the fireplace. I'm pretty sure it's not the Emacs version that is at fault but an incompatibility with an extension, plugin or configuration set in your .emacs

thomas-louvigne commented 8 years ago

@w1gz Yea, i am sure it is a .emacs problem, but where is the problem...

davidw commented 8 years ago

For me the problem was show-trailing-whitespace. I suppose this should turn that off locally.

w1gz commented 8 years ago

@zobi8225 If you're lost or can't figure it out, just gradually comment/uncomment your .emacs (dichotomy helps here!)

johanvts commented 8 years ago

I renamed the issue since it broadened a bit. I think some of the settings could be overridden on a pr. buffer basis to avoid people seeing these errors. I will add that tast to the todo list.

thomas-louvigne commented 8 years ago

I have commented this lines and it's better (but not perfect...)

;; (setq-default show-trailing-whitespace t)
;; (setq-default show-leading-whitespace t)
;; (setq-default indicate-empty-lines t)

Image of fireplace

jaxspades commented 8 years ago

I have the same issue with the above screenshot. I think it doesn't like line numbers. :)

Or rather, line numbers don't like it. I have various buffers, including Org mode ones, that have issues with line numbers.

AdrieanKhisbe commented 8 years ago

I just pushed a fix 1ba1234 that should take care of these rendering issues. It has been released under 1.1.1, and will be on melpa next build.

@zobi8225 @jaxspades @davidw @w1gz could you tell me if it works for you?

w1gz commented 8 years ago

@AdrieanKhisbe fresh from MELPA and working perfectly :). Thank you.

AdrieanKhisbe commented 8 years ago

you're welcome :) closing the issue then!

thomas-louvigne commented 8 years ago

@AdrieanKhisbe : Yes ! Now it works ! Thx !

AdrieanKhisbe commented 8 years ago

:fire_engine: :wink: