search

johanvts / emacs-fireplace

A cozy fireplace for emacs.
732 stars 21 forks source link

Add sound feature #31

Closed KaratasFurkan closed 4 years ago

coveralls commented 4 years ago

Coverage Status

Coverage increased (+2.2%) to 92.473% when pulling a431a10073459bdaa402e67ea0fc3dad2a2325c9 on KaratasFurkan:feature/sound into 571ffa7dd0ce46edca838df74d055aaa83da4d78 on johanvts:master.

AdrieanKhisbe commented 4 years ago

Hello @KaratasFurkan, following up on your mail I lately saw:

I think the best to test out your feature is via an integration test

For instance something like

  Scenario: Turn on the fire make it noisy then not
    When I call "fireplace"
    And  I switch to buffer "*fireplace*"
    And  I call "fireplace-toggle-sound"
    And  I wait for 1 second
    And  I call "fireplace-toggle-sound"

in the file https://github.com/johanvts/emacs-fireplace/blob/master/features/emacs-fireplace.feature

I can try to do it directly if you allow me to push on your branch

KaratasFurkan commented 4 years ago

Hello @AdrieanKhisbe, thanks for help. I send you an invitation.

AdrieanKhisbe commented 4 years ago

@KaratasFurkan received :), let see how 0dfb22a goes

johanvts commented 4 years ago

Nice work, go ahead @AdrieanKhisbe

AdrieanKhisbe commented 4 years ago

@johanvts Here it is: f6c23e2 v1.2.0 :sound: