search

johanvx / typst-undergradmath

A Typst port of undergradmath
Creative Commons Attribution Share Alike 4.0 International
109 stars 7 forks source link

Add custom operator section #28

Closed Weissnix4711 closed 1 year ago

Weissnix4711 commented 1 year ago

From docs.

johanvx commented 1 year ago

Thanks for your contribution and sorry for being late!

This section is really great, but it seems to break the two-page layout of the document[^1]. Would you like to do some extra modification (no matter which part of the document) to keep the output PDF in 2 pages?

Another improvement for this PR is to adopt Conventional Commits[^2], for which the workflows (the one that makes releases indeed) are designed.

[^1]: I should have mentioned this in a CONTRIBUTING.md :flushed: [^2]: Again, I should have prepare a CONTRIBUTING.md...

Weissnix4711 commented 1 year ago

Thanks for your contribution and sorry for being late!

Absolutely no worries mate.

  • I should have mentioned this in a CONTRIBUTING.md 😳 ↩

  • Again, I should have prepare a CONTRIBUTING.md... ↩

Honestly, I didn't even check for any contrib guidelines, so wouldn't have made a difference either way. I just threw this together in a min lol.

My local env seems a bit different from your ci, so I'll give gh actions a kick and see what it spits out. As for commit naming convention, lmk what to call it and ill squash everything. Otherwise, feel free to just rebase and reword yourself.

johanvx commented 1 year ago

The CI is intended to compile the PDF iff undergradmath.typ is modified.

As you can see here, the output file is a 3-page document. This is because there's nearly no space for a new section in release v1.0.0. So I suggest to shrink other sections to free up some space for a new section.

johanvx commented 1 year ago

I've made a fix commit to the math-op branch to keep the document in 2 pages (see here) and you can use Sync fork to update your math-op branch.