search

johanw666 / Signal-Android

Fork from a private messenger for Android with extra options added: full backup and (partial, ony text) xml backup of messages. Restore can happen at any time, not only after a fresh install. Import SMS database. Import of (unencrypted) WhatsApp databases. Removed apk expire. Choose between passphrase protection and the Android screenlock. Choice for the backup location (internal or removable storage on Android < 11 (on 11 and higher this is already possible)). Set the maptype in the place picker. Option to treat view-once media as normal media. Option to ignore remote deletion. Choose between FCM or websocket notification delivery.
https://johanw.home.xs4all.nl/Signal/signal-jw.html
GNU Affero General Public License v3.0
250 stars 16 forks source link

Chat background on AMOED Black are now off black #3

Open Sn0whax opened 4 years ago

Sn0whax commented 4 years ago

When using 4.47.5.0-JW it appears the background is inherited from dark mode instead of the OLED black theme. The contact list appears to be fine.

Would it also be possible to change the group chat header from blue to OLED black when using group chats?

Thanks again!

johanw666 commented 4 years ago

I can't remember if it once worked otherwise. It looks black to me but I don't have an OLED screen so both probably look the same on my device. I'll check the code if I find the time. The header is a separate issue, that is not quickly changed because it would also influence the font color of the text there.

Sn0whax commented 4 years ago

Yeah, I've tried playing with the group chat header with no luck either.

Regarding the OLED color, it has changed for sure. I tried reverting back to some of your earlier versions where you had started implementing it and the chats were a pure black. I can also look into it when i have some time, I'm just super inefficient at it.

johanw666 commented 4 years ago

The theme system was seriously overhauled in 4.50, I've made some changes in 4.50.5.1-JW to correct some theme issues. The amoled theme should be fixed by them, some other themes still need some refinement.

Sn0whax commented 4 years ago

I'd like to reopen this I've tried 4.50.5.1 and the latest 4.55.8.0-JW. The main list of chats is OLED black. However, once you enter an individual chat the background is the stock, off-black. I continue to use 4.38.3.0-JW, there may be slightly later versions that appear to have this fix but I randomly selected a few versions between 4.50.5.1 with it continuing to be off grey. Is there any way to compare the chats in 4.38.3.0-JW to the latest version and update the grey to the black?

johanw666 commented 4 years ago

Which version of Android are you using? There are some different settings for different versions because some Android versions don't support all options that are used. I might have overlooked something here.

Sn0whax commented 4 years ago

I've tested this on a s8 in android 8 and a s10 on android 9. I can also test it next week on a OnePlus 7t on android 10.

I've tried playing with the systemwide dark mode but it doesn't change this app.

Sn0whax commented 4 years ago

This also happens for the OnePlus 7T on android 10.

Sn0whax commented 4 years ago

Check out: https://github.com/mollyim/mollyim-android

They have managed to make it all OLED black, sadly they removed the ability to text. I believe this may resolve the OLED issues.

thrdroom commented 2 years ago

This seems to be broken since 2019, and it would make a difference to a lot of people with amoled screens for preserving battery life, and also for the aesthetics of the app.

@johanw666

  1. Can you "simply" merge the code for the amoled theme from molly?
  2. Are you still working on the features and bugs of this app, or are you "only" building new builds when the signal team has updated something? Is this fork abandoned in terms of new features being developed, and bugs being fixed?

No disrespect from my side, i just want to know if the open bugs will be fixed(are worked on) at any time or if we should move on to other forks or back to vanilla signal at some point.

Thanks anyhow for your fork 💪

johanw666 commented 2 years ago

I removed the extra themes some time ago because maintaining them was too much work with the constant UI redesigns. I am open to new features, to a limit: it has to be maintainable for me, and I must see the need for the function.

Using the Molly code would mean I replace the current dark theme with it, which would be bad for those people prefering using dark mode as it is now.

thrdroom commented 2 years ago

Thanks for fast answer 🙂

Using the Molly code would mean I replace the current dark theme with it, which would be bad for those people prefering using dark mode as it is now.

Could mollys amoled theme and default non amoled dark theme co exist at the same time (selectable in settings)? It sounds like you don't want to maintain your own themes because of the many changes from vanilla signal. That way you would "only" need to maintain the theme-selection part in the settings and the rest of the code comes from outside repos. So could it be an option to always merge the amoled theme from molly, into your existing code?

Or is this out of the scope too?

johanw666 commented 2 years ago

Could mollys amoled theme and default non amoled dark theme co exist at the same time (selectable in settings)?

Yes, that was the solution I had before. However, I kept spending hours to maintin that, and honestly all for a solution I don't even use myself (I use the light theme myself).

ghost commented 1 year ago

@thrdroom @Sn0whax I don't know if this will help but since johan can't maintain the AMOLED Dark anymore because he is busy and he has all my respect for that, I made a fork of his repo, and I made a script that changes the color of the classic dark theme to the AMOLED one, the process is fully automated whenever he publishes a new release it won't take more than 24 hours to update my fork with the latest changes and publishing the AMOLED dark version.

check here: https://github.com/JohnBetaro/Signal-Android-AMOLED-Dark-Plus