johanw666 / Signal-Android

Fork from a private messenger for Android with extra options added: full backup and (partial, ony text) xml backup of messages. Restore can happen at any time, not only after a fresh install. Import SMS database. Import of (unencrypted) WhatsApp databases. Removed apk expire. Choose between passphrase protection and the Android screenlock. Choice for the backup location (internal or removable storage on Android < 11 (on 11 and higher this is already possible)). Set the maptype in the place picker. Option to treat view-once media as normal media. Option to ignore remote deletion. Choose between FCM or websocket notification delivery.
https://johanw.home.xs4all.nl/Signal/signal-jw.html
GNU Affero General Public License v3.0
250 stars 16 forks source link

Backup files not encrypted even if selected in settings #37

Closed johanw666 closed 2 years ago

johanw666 commented 2 years ago

For everyone who uses my fork, I, must admit I made an error. While I always warn against encryption that is difficult to test because even if it is not really safe due to some bug but it seems to work OK, I now felt in exactly that trap.

Signal changed the way to check if a backup is selected from the shared settings to the Signal settings store, but kept the old method in place. Therefore my encrypted and plaintext backups didn't think a normal backup was setup and didn't encrypt the resulting zip files.

If you have stored such backups somewhere, check if they are really encrypted and take measures if they are not.

I fixed the code in 5.25.8.1-JW.

Sorry for any inconvenience caused by this issue.

johanw666 commented 2 years ago

Fixed in https://github.com/johanw666/Signal-Android/commit/6f2ccaa90da65256fceb00aff7953a1370e7f9cb