johanw666 / Signal-Android

Fork from a private messenger for Android with extra options added: full backup and (partial, ony text) xml backup of messages. Restore can happen at any time, not only after a fresh install. Import SMS database. Import of (unencrypted) WhatsApp databases. Removed apk expire. Choose between passphrase protection and the Android screenlock. Choice for the backup location (internal or removable storage on Android < 11 (on 11 and higher this is already possible)). Set the maptype in the place picker. Option to treat view-once media as normal media. Option to ignore remote deletion. Choose between FCM or websocket notification delivery.
https://johanw.home.xs4all.nl/Signal/signal-jw.html
GNU Affero General Public License v3.0
250 stars 16 forks source link

Plaintext Export does not contain MMS group messages #44

Open joeposner opened 2 years ago

joeposner commented 2 years ago

Let's begin with a checklist: Replace the empty checkboxes [ ] below with checked ones [x] accordingly. -->

I'm using your fork of Signal and have successfully imported a backup database from Signal; old group chant messages appear as expected in that import.

However, when I use the Plaintext export, these MMS messages do not appear to be in the exported file. A grep of the SignalPlaintextBackup.xml file for Signals standard group Id returns no values. Ex:

grep nal_mms_group SignalPlaintextBackup.xml

Likewise, greps in that file for mms or text from a group chat produces no results.

And, as expected with the results of those greps, an import with SMS Backup and Restore, the group chats do not appear

johanw666 commented 2 years ago

Yes, media messages are not saved in the xml export. Adding the text part of those to the export is on my planning.

joeposner commented 2 years ago

Would you consider accepting a pull request from me to add this feature?

johanw666 commented 2 years ago

Certainly, it would safe me some work. I have already made provisions in the code for media message export but it does not work yet and is behind an if (false). It is in PlaintextBackupExporter.java in exportPlaintext() and in some changes in mmsDatabase.java.