search

johanw666 / Signal-Android

Fork from a private messenger for Android with extra options added: full backup and (partial, ony text) xml backup of messages. Restore can happen at any time, not only after a fresh install. Import SMS database. Import of (unencrypted) WhatsApp databases. Removed apk expire. Choose between passphrase protection and the Android screenlock. Choice for the backup location (internal or removable storage on Android < 11 (on 11 and higher this is already possible)). Set the maptype in the place picker. Option to treat view-once media as normal media. Option to ignore remote deletion. Choose between FCM or websocket notification delivery.
https://johanw.home.xs4all.nl/Signal/signal-jw.html
GNU Affero General Public License v3.0
252 stars 16 forks source link

Do not add country prefix to sms to be sent #72

Closed jbrepogmailcom closed 1 year ago

jbrepogmailcom commented 1 year ago

Hello I have suggestion to fix bug that comes from original Signal app, that would make your version even better than Original. In the original, the development team refused to fix the bug because they are stepping away from SMS, but many people do not want it so I think they will turn to your version.

Bug description Describe here the issue that you are experiencing.

There are some local country numbers for SMS (short numbers, Premium-SMS), that use shortened number and are only country specific, so they only work without country prefix. For example SMS sent to number 9020626 can pay for ticket. But Signal automatically adds country prefix even when the number is stored in contacts without the prefix, so in my case Signal creates recipient number as +42090202626 from contact number 9202626 ad then tries to send SMS to that number. It does not work. So signal does not allow to send premium SMS and needs to be turned off as default SMS application and other SMS application needs to be set as default in order to send premium SMS.

Steps to reproduce try to send premium SMS to number without country prefix error that SMS cannot be sent

johanw666 commented 1 year ago

Turning to my version because Signal will drop sms is not advisable, I also won't maintain sms support. That is way too much work, if it is even possiblle in a neat manner when phone number privacy is introduced. As a start I alreaady had to drop the import from the system sms database in 6.5 dus to code changes.

I believe Silence has some hacks to deal with short numbers in sms messages.