search

johentsch / ms3

A parser for annotated MuseScore 3 files.
https://ms3.readthedocs.io
GNU General Public License v3.0
41 stars 3 forks source link

The excerpt update (revised) #105

Closed leobruneau closed 10 months ago

leobruneau commented 11 months ago

Problems from last pull request have been addressed and now everything should be in order

leobruneau commented 10 months ago

Hi @johentsch! No, I did not run the unittests as a matter of fact. The bug was caused by me overlooking some lines of code. I've already solved the bug, so all the unittests should now go through. Sorry for the inconvenience

johentsch commented 10 months ago

Thanks, would you mind pushing the fix?

leobruneau commented 10 months ago

Yeah sure! It should be all fixed now (I pushed the changes on my main branch with which I'm calling the merge contribution). Let me know if the bug has been fixed on your end too

johentsch commented 10 months ago

I'm not sure I understand what you mean. This PR is identical to your main branch. This is the version that causes the bug I've reported above. This is the bug that needs fixing before this PR can be merged and for that we need to see at least one additional commit to this PR/your main branch.

leobruneau commented 10 months ago

Now it should be all right. Let me know if that is not the case on your end