joheras / IJ-OpenCV

GNU General Public License v3.0
29 stars 13 forks source link

Remove example plugins jars from the plugin folder #24

Closed LauLauThom closed 5 years ago

LauLauThom commented 5 years ago

The example plugins are anyway shipped with IJ-OpenCV.jar. But the update site also ships the example plugins as separate jars in Fiji.app/plugins.

This has the drawback to show a long WARNING message when Fiji is run in headless mode. Fiji basically complains that one of the 2 is overwriting the other. It also increases the number of packages to download unnecessarily.

I would thus advise to remove the ones in Fiji.app/plugins from the update site, it would also makes things easier when contributing to the repo in the example section. There is only a single jar to compile.

The warning messages

[INFO] Overriding Adaptive Threshold; identifier: command:com.mycompany.adaptivethresholdj.Adaptive_ThresholdJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/AdaptiveThresholdJ-1.0-SNAPSHOT.jar
[INFO] Overriding BGR Histogram Comparison; identifier: command:com.mycompany.bgrhistogramcomparisonj.BGR_Histogram_ComparisonJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/BGRHistogramComparisonJ-1.0-SNAPSHOT.jar
[INFO] Overriding BlackHat; identifier: command:com.mycompany.blackhatj.BlackHatJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/BlackHatJ-1.0-SNAPSHOT.jar
[INFO] Overriding Canny Edge Detection; identifier: command:com.mycompany.cannyedgedetectionj.CannyEdgeDetectionJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/CannyEdgeDetectionJ-1.0-SNAPSHOT.jar
[INFO] Overriding Convex Hull from Polygon ROI; identifier: command:com.mycompany.convexhullfrompolygonroij.ConvexHullFromPolygonROIJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/ConvexHullFromPolygonROIJ-1.0-SNAPSHOT.jar
[INFO] Overriding Detect circles; identifier: command:com.mycompany.detectcircles.DetectCirclesJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/DetectCirclesJ-1.0-SNAPSHOT.jar
[INFO] Overriding Face detection; identifier: command:com.mycompany.facedetectionj.FaceDetectionJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/FaceDetectionJ-1.0-SNAPSHOT.jar
[INFO] Overriding Find contours; identifier: command:com.mycompany.findcontoursj.FindContoursJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/FindContoursJ-1.0-SNAPSHOT.jar
[INFO] Overriding HSV Histogram Comparison; identifier: command:com.mycompany.hsvhistogramcomparisonj.HSV_Histogram_ComparisonJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/HSVHistogramComparisonJ-1.0-SNAPSHOT.jar
[INFO] Overriding High dynamic range imaging; identifier: command:com.mycompany.highdynamicrangeimagingj.High_Dynamic_Range_ImagingJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/HighDynamicRangeImagingJ-1.0-SNAPSHOT.jar
[INFO] Overriding Hough lines; identifier: command:com.mycompany.houghlinesj.HoughLinesJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/HoughLinesJ-1.0-SNAPSHOT.jar
[INFO] Overriding Keypoint detector; identifier: command:com.mycompany.keypointdetectorj.KeyPointDetectorJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/KeyPointDetectorJ-1.0-SNAPSHOT.jar
[INFO] Overriding Kmeans clustering; identifier: command:com.mycompany.kmeansclusteringj.KMeans_ClusteringJ; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/KMeansClusteringJ-1.0-SNAPSHOT.jar
[INFO] Overriding Non local means denoising; identifier: command:com.mycompany.nonlocalmeansdenoisingj.Non_Local_Means_DenoisingJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/NonLocalMeansDenoisingJ-1.0-SNAPSHOT.jar
[INFO] Overriding Stitching; identifier: command:com.mycompany.stitchingj.StitchingJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/StitchingJ-1.0-SNAPSHOT.jar
[INFO] Overriding Template matching; identifier: command:com.mycompany.templatematchingj.TemplateMatchingJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/TemplateMatchingJ-1.0-SNAPSHOT.jar
[INFO] Overriding Whitehat; identifier: command:com.mycompany.whitehatj.WhiteHatJ_; jar: file:/C:/Users/Laurent/Desktop/Fiji.app/plugins/IJ-OpenCV-plugins/WhiteHatJ-1.0-SNAPSHOT.jar
joheras commented 5 years ago

Done. Sorry for the delay. Best, Jónathan

LauLauThom commented 5 years ago

Thanks, I notice you also removed the cascade for face detection from the lib folder. image This one should stay, it was easier to open it from there than from the jar 😅 See https://github.com/joheras/IJ-OpenCV/issues/17

joheras commented 5 years ago

Fixed. Thanks.