search

joheras / IJ-OpenCV

GNU General Public License v3.0
30 stars 13 forks source link

Consider adding continuous integration and semantic versioning #27

Open imagejan opened 3 years ago

imagejan commented 3 years ago

I noticed that the pom.xml of this repository lists a non-snapshot version:

https://github.com/joheras/IJ-OpenCV/blob/0fde433cc8cdde5fc13db4c0427c3b258d2c7783/pom.xml#L12-L14

This can lead to situations where several different jar files appear to be the same version, as recently noticed by Manuel Gunkel and @LauLauThom in this forum topic.

I recommend adhering to SemVer (semantic versioning) and using -SNAPSHOT versions on any commits to master, and ideally using the release-version.sh script provided for the community by SciJava. This might be a good opportunity to activate continuous integration via Travis CI for this repository. @joheras Let me know and I'll be happy to submit a pull request for travisifying this repo, so that releases can be deployed automatically to https://maven.scijava.org.

joheras commented 3 years ago

Thanks Jan, I will work on this. Feel free to submit the pull request. Best regards, Jónathan

El vie, 12 mar 2021 a las 21:14, Jan Eglinger @.***>) escribió:

I noticed that the pom.xml of this repository lists a non-snapshot version:

https://github.com/joheras/IJ-OpenCV/blob/0fde433cc8cdde5fc13db4c0427c3b258d2c7783/pom.xml#L12-L14

This can lead to situations where several different jar files appear to be the same version, as recently noticed by Manuel Gunkel and @LauLauThom https://github.com/LauLauThom in this forum topic https://forum.image.sc/t/ij-opencv-version-of-update-site-vs-github/49916?u=imagejan .

I recommend adhering to SemVer (semantic versioning) and using -SNAPSHOT versions on any commits to master, and ideally using the release-version.sh https://github.com/scijava/scijava-scripts/blob/8379c1fe9de7105b900479d8890fe17930b5560f/release-version.sh script provided for the community by SciJava. This might be a good opportunity to activate continuous integration via Travis CI https://imagej.net/Travis_CI for this repository. @joheras https://github.com/joheras Let me know and I'll be happy to submit a pull request for travisifying this repo, so that releases can be deployed automatically to https://maven.scijava.org.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joheras/IJ-OpenCV/issues/27, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJRAG3U5LO75KU2BQZSD73TDJY33ANCNFSM4ZC4N6AQ .