search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
372 stars 123 forks source link

Unit 8 - 3D Vision ... -> Section Introduction -> Sub Sections History and Applications #115

Closed vasugupta9 closed 6 months ago

vasugupta9 commented 6 months ago

Hi reviewers,

This PR is for Unit 8 - 3D Vision, Scene Rendering and Reconstruction. Section/Topic - Introduction and Sub-Section/Sub-Topics - History and Applications.

Authors History sub-section: Firoz (cywiz57) Applications sub-section: Vasu (vasu.9)

Thanks !

vasugupta9 commented 6 months ago

Yes, I think we can have Introduction as 1 markdown file.

Presently, we have separate markdown files since different owners were working on different sub-sections and no owner presently for subsection 'Overview of 3D vision' within section 'Introduction'.

Also, based on the 'Contribution guidelines' in Readme ( 7.1 Create .mdx files or Jupyter Notebooks for the sub-topics you want to contribute to), I felt it might be ok to have separate markdown files for now and once core 3D vision content is done, we can reorganise files as required !

vasugupta9 commented 6 months ago

Hi @merveenoyan, should I create a separate PR just for the Applications sub-section, so that applications.mdx could be merged with the main repo ? All feedback above for applications.mdx has been incorporated.

merveenoyan commented 6 months ago

@vasugupta9 you can have it in this PR if you feel like it. :)

merveenoyan commented 6 months ago

@vasugupta9 Can you commit @MKhalusova's suggestions and I'll give one last review? It should be close to merger

vasugupta9 commented 6 months ago

@merveenoyan Done committing suggestions above !

vasugupta9 commented 6 months ago

Thanks @johko . I have committed the remaining suggestions as well. Sorry, I think I missed noticing these suggestions because they were hidden !