search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
372 stars 123 forks source link

Fundamentals - Image and Imaging, Part 3 - "Imaging everything" #129

Closed bellabf closed 6 months ago

bellabf commented 6 months ago

Hello, hello, hello,

I am happy to send you the part 3 of imaging everything in your merry way. You can find this section in the ''extension-image.mdx". This section was written by me, and it was based on this outline.

I left a note for the reviewers in the text itself because between our original issue and the outline, one of the sections was split into two, so I thought it might have some confusion there.

If it is not too bothersome, might I ask for @ATaylorAerospace to fact-check me in the sections regarding astronomical observations? I tried my best to understand the material and to put into more simple terms. But it is possible I might have made some mistakes, and I don't know enough about it to correct them myself.

As you usual, thank you so much for the feedback imaging team concerned with this pr : @seshu-pavan bcc - @lunarflu @merveenoyan @MKhalusova

I know @johko said he is not the code owner so we shouldn't wait for his reviews, but he is mentioned on the text due to his early input, so I am also tagging him here.

Let's goooo, I can't wait to get the course out there!!!

merveenoyan commented 6 months ago

@bellabf I saw some comments aren't addressed, can you address it and request for review again?

bellabf commented 6 months ago

@bellabf I saw some comments aren't addressed, can you address it and request for review again?

Hi, Merve! I think I've addressed all the comments that were made previously :) Sending it back to you.

bellabf commented 6 months ago

I think we can merge this next. You can have these texts inside arrows in alt text inside the image or at the bottom of the page

Hi, again! I've added the text inside the arrow into the alt text, it should be good to go :)

bellabf commented 6 months ago

Really great work, could as well be part of a book ;) Left some grammar corrections, but apart from that LGTM 👍

Thank you! Everyone's feedback (@merveenoyan @ATaylorAerospace ) has been really encouraging. Thanks a lot. It means a lot to me :smile: