Closed sitloboi2012 closed 9 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hi , Great work but I think that more explanation is required. I would suggest introducing what type of model LayoutLM is, if it's associated with any research paper or not, tasks most suitable for LayoutLM etc. You can as well collaborate with people. Anticipating the changes soon🚀
Cool, thank you for your feedback, I will add on more information related to the model itself, any other relevants info that is helpful for other user
hi @chiho-5 , can you help me check the PR again? I made some updates related to adding information about the model background, related information like research paper, model card hub, huggingface docs, GitHub link and an introduction about the document image classification task as well
hi @chiho-5 , can you help me check the PR again? I made some updates related to adding information about the model background, related information like research paper, model card hub, huggingface docs, GitHub link and an introduction about the document image classification task as well
Okay. Give me some time to go through all of it. I've also requested for extra reviews. I'd give you my feedback and suggestions soon
Hi, Thanks for adding more information. It seems like some information is repeated in two different MD files. Can you resolve that please. Generic information should be in the ReadMe and then model specific information should be in the introduction file inside the folder.
cool, thank you everyone for the feedback, I will review it today and make change based on the feedback, will ping you guy when the update is done, pretty good start
hi @chiho-5 , @johko and @merveenoyan , i made some updates based on the team feedback, this includes: changing the notebook model from LayoutLMv1 to v3, updating the Introduction.md and the README.md to make it clearer, removing repetition and adjust some links to reduce the size a bit.
Have a look through to see if I still missed anything based on your guy's feedback, sorry if I made any grammatical errors or stuff 🤣
hey team, Im going to close this PR as it's quite big and try to break it down a bit. I will open a PR that its smaller and take in consideration @merveenoyan, @johko and @chiho-5 comment to make it better
README.md
andFine-tune-LayoutLM-For-Document-Image-Classification.ipynb
files for2 Neural Network Architectures / 2.3 Multi-Modal Model / 2.3.3 Transfer Learning