johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
452 stars 139 forks source link

3d measurements using stereo vision #133

Closed vasugupta9 closed 9 months ago

vasugupta9 commented 9 months ago

Hi reviewers,

This PR is for Unit 8 - 3D Vision, Scene Rendering and Reconstruction. Section/Topic - '3D measurements using Stereo Vision'

Authors 3d_measurements_stereo_vision.mdx: Vasu (vasu.9)

Please note present version (as of Dec 17th) is a draft version and plan to complete soon in 1-2 days. Will update here once ready for review.

[Dec 19th update] PR is ready for review ! Please also review the rendering for the images and let me know if any updates required. I am unable to preview using doc builder and not sure how the images and their titles would appear on the final course website !

Thanks !

vasugupta9 commented 9 months ago

Thanks much @ATaylorAerospace for such a detailed review and very helpful feedback !

vasugupta9 commented 9 months ago

@ATaylorAerospace Thanks for the detailed feedback ! I also learnt much about writing proper grammar. Is there a resource you can refer me for writing better grammar ?

ATaylorAerospace commented 9 months ago

@ATaylorAerospace Thanks for the detailed feedback ! I also learnt much about writing proper grammar. Is there a resource you can refer me for writing better grammar ?

Hello @vasugupta9 No your grammar is great! We all can make improvements here and there in terms of readability and I just focused on making portions of the unit a bit easier to understand.

vasugupta9 commented 9 months ago

Thanks much @merveenoyan for the detailed review and feedback !

vasugupta9 commented 9 months ago

@merveenoyan - terms converted to latex format. Thanks !