search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
373 stars 123 forks source link

Unit 5. Generative models - Introduction #142

Closed jere357 closed 6 months ago

jere357 commented 6 months ago

Helloo, this is the intro I've come up with for the generative modeling chapter, I use the introduction to introduce the readers to some common metrics they will come across while working with generative models + relevant papers if they want to know more. Feedback welcome and appreciated :hugs:

jere357 commented 6 months ago

Thanks for working on this. I don't have any comments to add to what others have pointed out. One question - what is the purpose of adding empty readme files to the PR?

I don't know, i just followed our plan as a group to have a separate repo + branches and this is what came out at the end

The folder structure in this unit is a bit weird, but i think it's gonna be okay when everyone's done with their parts, we can easily move everything to the root of unit 5

merveenoyan commented 6 months ago

@jere357 if you can make the filename Introduction.mdx and if you're not going to add more content to empty files we can merge the PR.

jere357 commented 6 months ago

@jere357 if you can make the filename Introduction.mdx and if you're not going to add more content to empty files we can merge the PR.

Done, i suggest double checking the folder structure of this unit and getting back to us

merveenoyan commented 6 months ago

We can merge this, we just require approval from community