search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
452 stars 139 forks source link

Unit 4 - Clip and relatives - Notebooks for applications of CLIP #150

Closed nemesisalm closed 9 months ago

nemesisalm commented 9 months ago

4 notebooks for applications of CLIP. Sorry about the delay, this was ready before the deadline but due to a miscommunication, it was not PR before

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

nemesisalm commented 9 months ago

Clustering notebook done according to your comments. Will work on the others in the upcoming days

nemesisalm commented 9 months ago

HI @merveenoyan . I have applied your comments to all 4 notebooks. Looking forward to hearing from you.

review-notebook-app[bot] commented 9 months ago

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2023-12-25T10:35:58Z ----------------------------------------------------------------

Can you remove backslashes?


nemesisalm commented on 2023-12-26T19:52:01Z ----------------------------------------------------------------

Done

nemesisalm commented 9 months ago

Done

View entire conversation on ReviewNB

nemesisalm commented 9 months ago

@merveenoyan All backlashes removed. Let me know if you need me to change anything else

merveenoyan commented 9 months ago

@nemesisalm lastly, we have changed the folder name to fix Multimodal*, is it okay if you could fix that and we can merge?

merveenoyan commented 9 months ago

Also you can remove empty files as we are merging them in a separate PR.

nemesisalm commented 9 months ago

@nemesisalm lastly, we have changed the folder name to fix Multimodal*, is it okay if you could fix that and we can merge?

Done

Also you can remove empty files as we are merging them in a separate PR.

Done

review-notebook-app[bot] commented 9 months ago

View / edit / reply to this conversation on ReviewNB

bellabf commented on 2023-12-27T13:18:41Z ----------------------------------------------------------------

This is sentence feels a bit awkward to me. Maybe "we use a rather small dataset for this demo".


review-notebook-app[bot] commented 9 months ago

View / edit / reply to this conversation on ReviewNB

bellabf commented on 2023-12-27T13:18:41Z ----------------------------------------------------------------

Backslashes


bellabf commented 9 months ago

Hi everyone. Really great tutorial, super easy to follow. Left some small comments, mostly about the little things that I think were left there on accident (like backslashes). I tried to point them out, so it you know where they are. :)

nemesisalm commented 9 months ago

@bellabf Thanks for the review. Changes implemented. I don't know what's wrong with the backlashes but I think this is solved now. Let me know if there is anything else to modify.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.