johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
372 stars 123 forks source link

This PR Introduces simple explaination for CycleGAN as part of Unit 5 : Generative Models #158

Closed charchit7 closed 6 months ago

charchit7 commented 6 months ago

Hey everyone! This PR adds CycleGAN to unit 5.

Part of #28

Please take a look! @MKhalusova @merveenoyan @mattmdjaga @hwaseem04

charchit7 commented 6 months ago

Looking good 👍👍, my main comment is just that there are many unnecessary line breaks.

Thanks you @mmhamdy 🤗 I'll change them, it's just my vscode is behaving weirdly.

charchit7 commented 6 months ago

Well written, would you consider adding PyTorch implementation of CycleGAN?

Thanks, Merve 🤗 Yes, I'll add it.

charchit7 commented 6 months ago

@merveenoyan @mmhamdy please check the PR, have fixed all the issues. For CycleGAN code I'll raise another PR.