search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
452 stars 139 forks source link

Adds basic structure of Stable diffusion and it's usecases. Part of Unit 5 #164

Closed charchit7 closed 8 months ago

charchit7 commented 9 months ago

Hey Everyone!

This PR adds basic structure of Stable Diffusion and it's use-cases. Part of https://github.com/johko/computer-vision-course/issues/28

Need advice here, since the content of SD can go super large if I go into depth is the basic structure fine here. @MKhalusova @merveenoyan @mattmdjaga @hwaseem04

merveenoyan commented 9 months ago

@charchit7 should I review this?

charchit7 commented 9 months ago

@charchit7 should I review this?

Yes, Merve. Thank you :) Just wanted to know if the flow and length of content was fine here.

charchit7 commented 9 months ago

Thanks a lot for this!!!

welcome 🤗

charchit7 commented 9 months ago

Hey @merveenoyan please check, fixed the required changes.

charchit7 commented 9 months ago

LGTM if you could accept my suggestions

Thanks @merveenoyan. Added the changes. Please have a look. Had forgotten the installation part earlier.

charchit7 commented 9 months ago

Just two small things, but in general LGTM 👍

I like the high level description that covers the most important parts of SD

Thanks @johko fixed the required changes. Please have a look.

merveenoyan commented 8 months ago

@charchit7 since we merged your other PR, is it ok if you can solve the merge conflict caused by that?

charchit7 commented 8 months ago

@charchit7 since we merged your other PR, is it ok if you can solve the merge conflict caused by that?

Hey @merveenoyan done. Please have a look.

charchit7 commented 8 months ago

@johko can I merge this pull request then? I can see the button. Please let me know.

johko commented 8 months ago

@charchit7 I'm merging it now