Closed wonhyeongseo closed 9 months ago
Dear @johko and @lunarflu ,
I've added black
and ruff
as pre-commit hooks. Should we also integrate them as GitHub Actions for added assurance on PRs? Would appreciate your input on the value of these linters as GitHub Actions given potential cost implications.
Thanks for your guidance.
Best, Won
One general question @wonhyeongseo : We currently don't have any config files for black and ruff (or a pyproject.toml to cover both). Is that a problem or will it just run with all the default settings now?
Dear @johko and @lunarflu ,
I've added
black
andruff
as pre-commit hooks. Should we also integrate them as GitHub Actions for added assurance on PRs? Would appreciate your input on the value of these linters as GitHub Actions given potential cost implications.Thanks for your guidance.
Best, Won
Thanks for bringing up! If I understand correctly, it's free for public repos + some small amount of usage, and is another layer of redundance. If so, SGTM, and we can remove if needed.
Sorry, forgot to give feedback regarding actions - I also think that it makes sense (and hopefully will be free for us). But you can do this in a separate PR. I think this one is good to merge
Fixes https://github.com/johko/computer-vision-course/issues/16
This PR integrates
black
andruff
as pre-commit hooks to improve our code quality and consistency. With these hooks in place, every code change will be automatically formatted according to the standards set byblack
and validated byruff
before commits.Changes
Added
black
as a pre-commit hook.Added
ruff
as a pre-commit hook.Benefits
black
, we can ensure that our Python codebase looks the same regardless of the author.ruff
will help catch potential errors or anti-patterns early, ensuring high-quality code.How to Test
pip install pre-commit
.pre-commit install
..py
or.ipynb
file.black
andruff
.Feedback and suggestions are welcome!
Thank you.