search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
371 stars 123 forks source link

update of _toctree.yml and spelling fixes #171

Closed seshupavan closed 5 months ago

seshupavan commented 5 months ago

Hello everyone, This PR has two minor changes

  1. The file name's spelling for definition.mdx is corrected from defination.mdx ( nothing inside the file has been changed).
  2. The .yml tree has been updated as per guide and chapter content for both of our Fundamentals and Imaging chapters.

Best, Fundamentals and Imaging Team

bcc- @bellabf, @aman06012003

seshupavan commented 5 months ago

I've updated with the changes you mentioned @MKhalusova . Please take a look :))

MKhalusova commented 5 months ago

Please remove the .mdx extension in all of the entries.

Also, a broader note (not just about these changes, but about the rest of the TOC as well)The _toctree.yml should be under chapters/en/. This way, for every course translation there will be its own _toctree.yml. At the same time, if you move the _toctree.yml under chapters/en/, the paths in each local will be simpler. E.g. - local: Unit 1 - Fundamentals/image_and_imaging/extension-image instead of - local: chapters/en/Unit 1 - Fundamentals/image_and_imaging/extension-image

The changes I mentioned here should be applied to the whole TOC, and the _toctree.yml should be moved under chapters/en. I think we also need to include @johko in this conversation since this affects the whole course.

johko commented 5 months ago

Hey, as @MKhalusova has way more plan of the structuring and the toctree file, I trust her on that. So can you move the file into chapters/en @seshu-pavan ? Once you have moved it there we can merge, as far as I can see

seshupavan commented 5 months ago

I moved the _toctree.yml from its original location /chapters/ into chapters/en/. Please take a look and lmk @MKhalusova and @johko

seshupavan commented 5 months ago

I hope i changed as you expected. Please take a look @MKhalusova