search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
371 stars 123 forks source link

[WIP] added cycleGAN notebook! #175

Closed charchit7 closed 5 days ago

charchit7 commented 5 months ago

Hey everyone!

This PR adds CycleGAN Notebook! Currently training the model is left.

Part of #28 Also, discussed in #158

Please take a look! @johko @MKhalusova @merveenoyan

review-notebook-app[bot] commented 5 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

charchit7 commented 5 months ago

@hwaseem04 I left mostly formatting nits, otherwise it looks good!

Thanks @merveenoyan :) I'll make the required changes.

I think you accidently tagged hwaseem04 😅

merveenoyan commented 5 months ago

ah sorry, removed.

charchit7 commented 5 months ago

@merveenoyan no problem at all. 🤗

sitamgithub-MSIT commented 5 months ago

@merveenoyan It's been a week for this PR. Also, suggested changes are committed as well. Should I assign myself as the reviewer and do a community review for this?

merveenoyan commented 5 months ago

@sitamgithub-MSIT hello, I don't see the changes incorporated unfortunately :/

charchit7 commented 5 months ago

@sitamgithub-MSIT I have yet to make changes. @merveenoyan I had an accident last week and my right hand was cut a little. Will complete this by this weekend. Hope it's fine.

johko commented 5 months ago

no worries @charchit7, health definitely goes first

klyap commented 5 months ago

Hi! I'm helping @charchit7 out with wrapping up this PR and addressing review comments!

charchit7 commented 5 months ago

Thank you so much @klyap :) Merve Et al. Please check :)

review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-02-01T07:43:33Z ----------------------------------------------------------------

just a small nit, can you also take the param names into single backtick to format them as code?


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-02-01T07:43:34Z ----------------------------------------------------------------

If you put a gap between the # and the word it will be rendered properly


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-02-01T07:43:35Z ----------------------------------------------------------------

Same here (for header rendering)


review-notebook-app[bot] commented 5 months ago

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-02-01T07:43:35Z ----------------------------------------------------------------

you could do single upload_folder https://huggingface.co/docs/huggingface_hub/guides/upload#upload-a-folder


klyap commented 5 months ago

Made formatting changes and also changed the upload step to just upload folder and not individual files!

klyap commented 4 months ago

lmk if you have other suggestions, @merveenoyan !

review-notebook-app[bot] commented 4 months ago

View / edit / reply to this conversation on ReviewNB

MKhalusova commented on 2024-02-14T13:51:55Z ----------------------------------------------------------------

"The below code downloads the zebra2horses dataset and places it in the same folder."


review-notebook-app[bot] commented 4 months ago

View / edit / reply to this conversation on ReviewNB

MKhalusova commented on 2024-02-14T13:51:56Z ----------------------------------------------------------------

Line #4.    # basic transforms

Is this comment really needed?


review-notebook-app[bot] commented 4 months ago

View / edit / reply to this conversation on ReviewNB

MKhalusova commented on 2024-02-14T13:51:57Z ----------------------------------------------------------------

Since you explain briefly what a residual block does, maybe also add a sentence or two about these other blocks.


review-notebook-app[bot] commented 4 months ago

View / edit / reply to this conversation on ReviewNB

MKhalusova commented on 2024-02-14T13:51:59Z ----------------------------------------------------------------

Line #73.    class FeatureMapBlock(nn.Module):

What does this type of block do?


johko commented 3 months ago

Hey @klyap, thanks for all the work you put in. It seems like the only thing that actually needs to be adressed now, is loading the dataset from the huggingface hub. I'll have a look how to make that work

johko commented 3 months ago

@klyap and @charchit7 I created a PR to the branch in the repo you have been working on it -> https://github.com/hwaseem04/computer-vision-course/pull/7 Not sure who has to review that, but it should contain all needed fixes, so we can finally merge this ;)

charchit7 commented 3 months ago

Hey @johko looks good to me :)

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.