search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
452 stars 139 forks source link

Unit 3 - OneFormer #188

Closed alanahmet closed 7 months ago

alanahmet commented 8 months ago

Links will change after images merge to hf-assests

https://github.com/johko/computer-vision-course/pull/177#pullrequestreview-1824443438

alanahmet commented 7 months ago

Feel free to decide on the image and merge

Hi @MKhalusova I make PR for semantic and panoptic segmentation images. As I understand there is no need to modify the example code to matching image output. Is that correct?

MKhalusova commented 7 months ago

Feel free to decide on the image and merge

Hi @MKhalusova I make PR for semantic and panoptic segmentation images. As I understand there is no need to modify the example code to matching image output. Is that correct?

I'm not sure what you mean. Can you explain?

alanahmet commented 7 months ago

Feel free to decide on the image and merge

Hi @MKhalusova I make PR for semantic and panoptic segmentation images. As I understand there is no need to modify the example code to matching image output. Is that correct?

I'm not sure what you mean. Can you explain?

Should I change the original code to match the code that gives the example output image?

MKhalusova commented 7 months ago

Should I change the original code to match the code that gives the example output image?

Up to you, what is important is that the code in the chapters/en/Unit 3 - Vision Transformers/oneformer.mdx executes without errors and the outputs that learners will get (if they choose to run it) will match what they see I the example.

alanahmet commented 7 months ago

Hi @MKhalusova, I have added an example image and corresponding code. Could you please check it?

MKhalusova commented 7 months ago

Hi @MKhalusova, I have added an example image and corresponding code. Could you please check it?

I checked everything, and it looks great! I think, we should add a line for dependencies, though:

!pip install -q natten

natten is required for DinatBackbone. And let's also add note that natten may take some time to install.
When done, feel free to merge, no need to ping me :)

alanahmet commented 7 months ago

I add dependency for natten library. Could you please merge it I don't have permission to write.