search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
452 stars 139 forks source link

Adding chapter for object detection. #202

Closed miniMaddy closed 7 months ago

miniMaddy commented 8 months ago

This is the chapter for object detection. I have just added small changes to the work already done by @abdullah-alnahas. Please suggest any changes if necessary.

bellabf commented 7 months ago

Hi! Great work. Left some minor suggestions for wording and rephrase some parts, so the task description remains general even when the output of object detection is not a bounding box. :)

miniMaddy commented 7 months ago

@merveenoyan , I have added the suggested changes, except for a few. I have added comments for that. Please check and let me know if it's fine. Thank You

merveenoyan commented 7 months ago

@miniMaddy I answered them, do you have any other questions

miniMaddy commented 7 months ago

Thanks a lot, I will push the changes by tonight then.

miniMaddy commented 7 months ago

All the comments are resolved. Please check and merge. Thank You

bellabf commented 7 months ago

All the comments are resolved. Please check and merge. Thank You

I am really sorry I forgot to commit my comments for two reviews last week :facepalm:. I had some minor suggestions just to keep things slightly more general. Otherwise, looks good to me :)

miniMaddy commented 7 months ago

Thanks @bellabf , I made the suggested changes. Thanks for correcting me on the detection boxes.

johko commented 7 months ago

merging :rocket: