Update toctree

[ratan]

• update toctree with missing chapter entry

[ratan]

Hi @mmhamdy Thanks for the feedback. I restricted this PR only to toc file now.

[ratan]

@bellabf @mmhamdy thanks for your feedback and latest commit has all your recommendations. I see that many other PR are touching the toc file for few chapters and it will be rebase issue as this PR changes many chapter first time in toc file, making many lines of changes. Can we merge this PR in this form? @bellabf i have reached to chapter owner for correct ordering, but only heard from one who will revert back by next week. Can i fix the reorder issue in chap 4, 5, 8 in next PR?

[ratan]

Thanks @merveenoyan, done the changes as suggested by you. Please have a look

[ratan]

Thats a good suggestion. However the folder naming convention is is different. so toc file can be tuned for either of the way. Lets @merveenoyan @bellabf also share what the final decision and the i will push the commit accordingly.

[bellabf]

Thats a good suggestion. However the folder naming convention is is different. so toc file can be tuned for either of the way. Lets @merveenoyan @bellabf also share what the final decision and the i will push the commit accordingly.

Thank you for all your good work and quick reactivity! @ratan :smile:

Great suggestion, @mmhamdy! I personally do not care too much on the style name the files as long as we follow the same style across all the course. IMO, the problem is that we are not aware of the order of the chapter for all the units (which I am guessing would make changing to the NLP convection harder, and there even be chapters that are self-contained and could fit in multiple places). The pro is that we would be forced to find out the order. The con is that if we get it wrong even once, there would be lots of renaming (which might make tracking the files a bit messy).

I think @merveenoyan has a better grasp on this and its long term impact, so I will wait for her opinion before re-reviewing the PR again.

Thanks again everyone :hugs:

[ratan]

Hi @mmhamdy sure, you are most welcome. I have dropped DM to few authers but didnt get confirmation. If you can help with ordering for 4, 5, 8, it will be really appreciated.

[mmhamdy]

Great! That sounds cool, I'll check the ordering in these units.

[johko]

Thanks for taking care of this :pray:

[merveenoyan]

@ratan we are following the one made for Audio Course: https://huggingface.co/learn/audio-course/chapter0/introduction

[ratan]

@merveenoyan are you suggesting to change the chapter names as suggested inhttps://huggingface.co/learn/audio-course/chapter0/introduction in this repo and update toc file? Hope this doesn't create big rebase issue with other PR already being reviewed? We can divide it into 2 parts?

1. merge this PR as such with order for 4,5,8 fixed
2. Later when 1 or 2 PR touching toc files is merged, i can create another PR just to change the chapter names Please suggest @bellabf @mmhamdy

[kfahn22]

I just wanted to add that I think the READMEs in the Unit folders will need to either be moved (if you want to keep them for posterity) or deleted.

[ratan]

@merveenoyan are you suggesting to change the chapter names as suggested inhttps://huggingface.co/learn/audio-course/chapter0/introduction in this repo and update toc file? Hope this doesn't create big rebase issue with other PR already being reviewed? We can divide it into 2 parts?

1. merge this PR as such with order for 4,5,8 fixed
2. Later when 1 or 2 PR touching toc files is merged, i can create another PR just to change the chapter names Please suggest @bellabf @mmhamdy

Please advise we if can go ahead with this suggestion?

[ratan]

@merveenoyan are you suggesting to change the chapter names as suggested inhttps://huggingface.co/learn/audio-course/chapter0/introduction in this repo and update toc file? Hope this doesn't create big rebase issue with other PR already being reviewed? We can divide it into 2 parts?

1. merge this PR as such with order for 4,5,8 fixed
2. Later when 1 or 2 PR touching toc files is merged, i can create another PR just to change the chapter names Please suggest @bellabf @mmhamdy

Please advise we if can go ahead with this suggestion?

@bellabf @mmhamdy @merveenoyan needs your input. Can you please check the above comment?

[merveenoyan]

@ratan AFAIK it should've followed already, but we can open a new PR or handle it in this PR if possible

[merveenoyan]

@ratan if you can run styling in this PR we can merge it

[ratan]

merging the changes