search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
370 stars 123 forks source link

Added mdx file for Fine-tuning for Object Detection file. #218

Closed Anindyadeep closed 3 months ago

Anindyadeep commented 4 months ago

This PR adds the mdx file for fine-tuning ViT for object Detection.

Anindyadeep commented 4 months ago

Hi @merveenoyan, sorry for adding this PR super late. I got very less bandwidth this month. But please do feel free to let me know whatever changes I need to do this PR I added, and let's close it as soon as possible.

Some doubts I have:

Anindyadeep commented 4 months ago

Thanks for the review @merveenoyan and @MKhalusova, I will address these comments and feedback as soon as possible by tomorrow or Wednesday almost :)

merveenoyan commented 4 months ago

@Anindyadeep thank you so much! we have few comments left :) after that, can you run make quality and add your chapter to toctree (also give yourself credit on the first chapter if you haven't)? This way all the checks will be green 😊

Anindyadeep commented 4 months ago

@Anindyadeep thank you so much! we have few comments left :) after that, can you run make quality and add your chapter to toctree (also give yourself credit on the first chapter if you haven't)? This way all the checks will be green 😊

Hey I am almost done, just to address the comments by @MKhalusova on adding images. That should be done once my asset PR in HuggingFace get's merged. Other than that, let me know if all looks good. Also where to put the credit?

merveenoyan commented 4 months ago

@Anindyadeep in chapter 0 I think everyone gives credit to themselves

Anindyadeep commented 4 months ago

Hi I addressed all the comments I guess, let me know if anything is left, and I tried to do make quality but I am failing this check, and upon checking it, does seem like that the error is from other chapter.

merveenoyan commented 3 months ago

if you can implement the following changes, the build one will go green https://github.com/johko/computer-vision-course/commit/8b410ff9b0210a0dbe86f540a040141f103e22c3 https://github.com/johko/computer-vision-course/commit/8b410ff9b0210a0dbe86f540a040141f103e22c3 https://github.com/johko/computer-vision-course/commit/bd5673b36b8b75a39e941a211ba10c023c349399 https://github.com/johko/computer-vision-course/commit/63cabaa80138bc3128b00163980576d58a19ce8f and we can merge

Anindyadeep commented 3 months ago

Hi @merveenoyan thanks for letting me know the changes, I implemented those accordingly. Hopefully now we are good for merge :)

merveenoyan commented 3 months ago

@Anindyadeep sorry apparently Maria has requested changes, we'll have to wait for her to approve this PR to merge (she's currently off)

Anindyadeep commented 3 months ago

@Anindyadeep sorry apparently Maria has requested changes, we'll have to wait for her to approve this PR to merge (she's currently off)

I see, no worries, let me know if I need to add/change anything else, would happy to do it :)

Anindyadeep commented 3 months ago

Thank you for iterating over this and addressing the changes. LGTM now!

Thanks and hopefully we can go for merge now :)