search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
370 stars 123 forks source link

GoogleNet #220

Closed themurtazanazir closed 3 months ago

themurtazanazir commented 4 months ago

GoogleNet with code

merveenoyan commented 4 months ago

can you run make quality

sezan92 commented 4 months ago

can you run make quality

@merveenoyan done in https://github.com/johko/computer-vision-course/pull/220/commits/6afb645870f7fe2910b4a65dc2c1707f7f5bc5c3

ratan commented 4 months ago

Some tests are failing, please look into it.

themurtazanazir commented 4 months ago

@ratan this error seems to be part of the main branch already. I can see it originating at Unit 13 - Outlook/hyena.mdx. I believe it is due to latex tags not being rendered in <Tip> tags. An issue has been raised around it as well #222.

merveenoyan commented 3 months ago

@themurtazanazir can you incorporate following changes and the CI will go green

https://github.com/johko/computer-vision-course/commit/8b410ff9b0210a0dbe86f540a040141f103e22c3 https://github.com/johko/computer-vision-course/commit/8b410ff9b0210a0dbe86f540a040141f103e22c3 https://github.com/johko/computer-vision-course/commit/bd5673b36b8b75a39e941a211ba10c023c349399 https://github.com/johko/computer-vision-course/commit/63cabaa80138bc3128b00163980576d58a19ce8f

themurtazanazir commented 3 months ago

@themurtazanazir can you incorporate following changes and the CI will go green

8b410ff 8b410ff bd5673b 63cabaa

@merveenoyan it seems these changes are in your PRs (#224 and #223 ). I can wait till these are merged and resync my PR with main afterwards, if there is no issue with that.

merveenoyan commented 3 months ago

@themurtazanazir since they're very small changes I'd rather have them fixed here and make your PR merged because my PR is quite large and will take time until it's merged

themurtazanazir commented 3 months ago

@merveenoyan understood. making changes.

sezan92 commented 3 months ago

@MKhalusova can you check and if okay approve the PR ?

merveenoyan commented 3 months ago

@themurtazanazir if you can solve merge conflicts Maria will review and we can ship ⛴️

sezan92 commented 3 months ago

@merveenoyan @MKhalusova the conflicts are solved. Thanks @themurtazanazir mate