search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
370 stars 123 forks source link

Last nits before shipping 🛳️ #228

Closed merveenoyan closed 3 months ago

snehilsanyal commented 3 months ago

Hey @merveenoyan I went through my chapters, can you fix these things (or let me know if I should open a PR separately):

Ethics and Bias Unit

Multimodal Models Unit In the introduction chapter, only one issue with one of the images which is not rendering here

charchit7 commented 3 months ago

In Unit 5 : Generative Models, Section on VAE : https://github.com/johko/computer-vision-course/pull/131 there's an issue with the latex equation. @sarthak247 could you please have a look :)

charchit7 commented 3 months ago

In Unit 5 : Introduction to CycleGAN #158 The link reference to DCGAN paper bracket is not closed. Let me know if I can raise a PR.

merveenoyan commented 3 months ago

@snehilsanyal @charchit7 feel free to open PRs 😊

hanouticelina commented 3 months ago

Hello @merveenoyan , I went through Unit 3- Vision Transformers/Vision Transformers for Image Segmentation.mdx. I noticed minor nits to fix :

Thank you!

lulmer commented 3 months ago

Hey @merveenoyan For Unit 13 : Hyena, there are problems with the latex symbol spacing (almost all latex blocks are affected) and greek letters not rendering properly (in the screenshot "gamma" and "theta" should be rendered in greek).

image

merveenoyan commented 3 months ago

@lulmer problem is with docbuilder and not our side

merveenoyan commented 3 months ago

@hanouticelina can you open a PR to this branch?

merveenoyan commented 3 months ago

@charchit7 @snehilsanyal can you open a PR to this branch or main branch please?

vasugupta9 commented 3 months ago

Hi @merveenoyan ,

Rendering fixes done. PR here. Below comments can be ignored. 😌

=== Ignore Updated comment - I have created a PR PR241 (to main branch) for minor fixes in Unit 8 - sub-section introduction to stereo vision. Will make all required updates within the next 1-2 days and update here. The feature on the documentation page to view markdown rendering looks good, so pls ignore my comments below. Rendering for PR241 is not showing on the documentation website yet but my guess is it will show eventually !

Previous comment (There are few minor rendering issues related to equations like in section 'Simplified Solution' , etc - here

I would like to correct these but last time I tried I had issues getting doc builder to run properly on my system.

Is there an easy way where I can just upload/point to a single markdown file and see its rendering without having to worry about correctness of toc-tree, etc ?

If there isn't such a tool, do you think it would be good to have one ? If so, I'd be happy to spend some time understanding the existing tool/flow and build this additional feature.)

===

Thanks !

hanouticelina commented 3 months ago

@hanouticelina can you open a PR to this branch?

Hello @merveenoyan, the PR is open : https://github.com/johko/computer-vision-course/pull/240

merveenoyan commented 3 months ago

@vasugupta9 you don't need to run doc-builder on your local, just modify the number of PR here (your latest PR is hosted here https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_241/en/Unit%200%20-%20Welcome/welcome)

vasugupta9 commented 3 months ago

@vasugupta9 you don't need to run doc-builder on your local, just modify the number of PR here (your latest PR is hosted here https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_241/en/Unit%200%20-%20Welcome/welcome)

yes, this helped a lot with fixing the rendering.