search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
370 stars 123 forks source link

Reviewed general punctuation and fixed some broken links #251

Open sergiopaniego opened 2 months ago

sergiopaniego commented 2 months ago

In this PR I've:

I've used https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_246/en/Unit%200%20-%20Welcome/welcome as a source to find the issues.

Let me know if the course is updated elsewhere and I'll update it accordingly. This PR may cause merge issues with https://github.com/johko/computer-vision-course/pull/250, so I could update it once the former is merged

sergiopaniego commented 2 months ago

Thanks for the feedback @merveenoyan! Would you like me to make modifications regarding the punctuation? I'll review Chapter 9 for broken image links. For now, I've merged the updated main branch :smile:

sergiopaniego commented 2 months ago

I've indicated where the update links are located. I could even generate a separate PR just with the broken links if that's easier for merging :smiley:

merveenoyan commented 2 months ago

@sergiopaniego given the amount of fixes I think you should add your name to credits

sergiopaniego commented 2 months ago

I've updated the files with all the suggestions, accepted your commits, and restored a broken link to a chapter. Please let me know if there's anything else that needs attention!

@sergiopaniego given the amount of fixes I think you should add your name to credits

How should I add myself @merveenoyan?

Thanks for the in-depth review!

merveenoyan commented 2 months ago

@sergiopaniego when we make comments we would like to make them general, please reflect them across the text or I have to fix them one by one which takes a lot of time

merveenoyan commented 2 months ago

@sergiopaniego you can give yourself credit on credits section in 0th chapter

sergiopaniego commented 1 month ago

@sergiopaniego when we make comments we would like to make them general, please reflect them across the text or I have to fix them one by one which takes a lot of time

Thank you for all the suggestions and your thorough review. Apologies for my delayed responses (been busy with work and a conference).

I've accepted all your suggestions. I'll conduct a detailed review of the entire PR to ensure that all the suggestions are reflected.

sergiopaniego commented 1 month ago

Hi @merveenoyan :smile: I've conducted the review and the PR is now ready to be checked.

I've removed some punctuation thanks to your suggestions and updated some broken links that I've found while reviewing (https://github.com/johko/computer-vision-course/commit/1c20a24300d48296ee7f3a0c2ba2124593179cc2)

sergiopaniego commented 10 hours ago

Thanks @johko! :smile: