johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
365 stars 121 forks source link

Remove the redundant line of code #280

Open mohammad-gh009 opened 2 months ago

mohammad-gh009 commented 2 months ago

self.b1 = BaseConv2d(in_channels, n1x1, kernel_size=1)

this line of code was redundant in the GoogleNet architecture.

merveenoyan commented 2 months ago

@mohammad-gh009 can you resolve merge conflicts? resnet PR has changed the file a bit

mohammad-gh009 commented 1 month ago

@merveenoyan I resolved the merge conflict.

merveenoyan commented 1 month ago

@mohammad-gh009 you need to pull this and run the code_formatter.py script

mohammad-gh009 commented 2 weeks ago

Done !

mohammad-gh009 commented 2 weeks ago

@merveenoyan hey merve, can you review this code?