unit 8 fixes - latex stuff and broken link minor corrections

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord

MIT License

365 stars 121 forks source link

unit 8 fixes - latex stuff and broken link minor corrections #285

Closed psetinek closed 2 months ago

psetinek commented 2 months ago

Some fixes for chapter 8:

mainly latex related where I changed $...$ to $ ... $.
fixed Rotation matrix around z-axis in the linear algebra mdx.
fixed path to image for NeRF encodings in nerf mdx.

sergiopaniego commented 2 months ago

Could it be better if there was a space between the Latex text and the rest? Like in here:

Reference: https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_285/unit8/3d-vision/nvs

bellabf commented 2 months ago

Could it be better if there was a space between the Latex text and the rest? Like in here:

Reference: https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_285/unit8/3d-vision/nvs

I actually do not really know how to fix this. There is a similar problem with image.mdx in unit 1. I found digging some other PR that it was mentioned https://github.com/johko/computer-vision-course/pull/228#issuecomment-2006591074 that the problem was from the docbuilder. Since multiple units have this problem, it would be better to fix the docbuilder.

Maybe @merveenoyan or @johko know more about this?

merveenoyan commented 2 months ago

@sergiopaniego @bellabf unfortunately this is an error on docbuilder's side

merveenoyan commented 2 months ago

@psetinek would you be down to maybe write HTML to center images and the text underneath?