search

johko / computer-vision-course

This repo is the homebase of a community driven course on Computer Vision with Neural Networks. Feel free to join us on the Hugging Face discord: hf.co/join/discord
MIT License
376 stars 124 forks source link

DRAFT of mdx file discussing Physically Based Rendering #63

Closed kfahn22 closed 7 months ago

kfahn22 commented 7 months ago

This is an updated, more detailed version of Synthetic Data Creation / blenderProc.mdx. I tried to incorporate the comments already made about the first version. I am asked for feedback for ONLY this file.

I have not added the elephant image referenced in the file to the course-assets repo as I was not sure about procedure. Do we have permission to push to Dataset? Should the image be in a separate folder for Synthetic Data Creation? I would also like to eventually add the animal models I created. (In addition to an elephant, I made a rhino and lemur.)

It is not wonderful, but maybe good enough?

rendered_elephant3

Note: In line 92 I would like to link to the notebook - do I use a relative link?

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kfahn22 commented 7 months ago

I have deleted the files not related to PBR from this branch.

kfahn22 commented 7 months ago

@MKhalusova It is my intention to add a discussion on the limitations of synthetic data.

MKhalusova commented 7 months ago

@MKhalusova It is my intention to add a discussion on the limitations of synthetic data.

Awesome!

kfahn22 commented 7 months ago

I just added the links to the images